[py] Deprecate CDP methods on Firefox #14787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viet Nguyen Duc <[email protected]>
This reverts commit 49148e6.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Failure Feedback 🧐(Checks updated until commit ef0d787)
|
Signed-off-by: Viet Nguyen Duc <[email protected]>
VietND96
force-pushed
the
cdp-firefox
branch
2 times, most recently
from
1b2bb39 to
43c569b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #14787 +/- ##
==========================================
- Coverage 59.24% 59.21% -0.04%
==========================================
Files 94 94
Lines 6004 6009 +5
Branches 268 268
==========================================
+ Hits 3557 3558 +1
- Misses 2179 2183 +4
Partials 268 268 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
VietND96
force-pushed
the
cdp-firefox
branch
from
43c569b to
657f5d3
Compare
Signed-off-by: Viet Nguyen Duc <[email protected]>
VietND96
force-pushed
the
cdp-firefox
branch
from
657f5d3 to
ef0d787
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
This pull request introduces deprecation warnings for CDP (Chrome DevTools Protocol) support in Firefox and updates the corresponding tests. The most important changes include adding a deprecation warning in the
webdrivermodule and ensuring that the tests handle these warnings appropriately.Deprecation warning for CDP support in Firefox:
py/selenium/webdriver/remote/webdriver.py: Added a deprecation warning for CDP support in Firefox, advising users to switch to WebDriver BiDi.Updates to tests to handle deprecation warnings:
py/test/selenium/webdriver/common/devtools_tests.py: Modified thetest_check_console_messagestest to check for the deprecation warning when using Firefox.py/test/selenium/webdriver/firefox/firefox_service_tests.py: Updated thetest_log_output_as_filenametest to ensure no warnings are recorded.py/test/selenium/webdriver/remote/remote_firefox_profile_tests.py: Added a check to ensure no warnings are recorded when initializing theRemotedriver with Firefox options.Motivation and Context
Types of changes
Checklist
PR Type
enhancement, tests
Description
Changes walkthrough 📝
webdriver.py
Add deprecation warning for CDP in Firefoxpy/selenium/webdriver/remote/webdriver.py
devtools_tests.py
Update tests to handle Firefox CDP deprecationpy/test/selenium/webdriver/common/devtools_tests.py
firefox_service_tests.py
Ensure no warnings in Firefox service testspy/test/selenium/webdriver/firefox/firefox_service_tests.py
remote_firefox_profile_tests.py
Ensure no warnings in remote Firefox profile testspy/test/selenium/webdriver/remote/remote_firefox_profile_tests.py